fix(menubar): add Cycle Theme action under Help menu (closes #453) - #474
Open
EVWorth wants to merge 1 commit into
Open
fix(menubar): add Cycle Theme action under Help menu (closes #453)#474EVWorth wants to merge 1 commit into
EVWorth wants to merge 1 commit into
Conversation
Theme is cycleable from TitleBar (Windows/Linux) and Toolbar (macOS inline). The native and inline MenuBar had Check-for-Updates but no theme action, leaving macOS users without a single-click shortcut and inconsistent with VS Code / DataGrip / IntelliJ conventions. Adds: - 'Cycle Theme' under Help menu in MenuBar - Dispatches the 'cycle-theme' menu-action event - AppLayout handleAction routes that id to a Dark \u2192 Light \u2192 System cycle via the existing useThemeStore (mirrors Toolbar.cycleTheme) 2 new MenuBar tests verify the entry exists and dispatches the correct event id. Closes #453 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Theme was cycleable from TitleBar (Windows/Linux) and Toolbar (macOS inline). The MenuBar had Check-for-Updates but no theme action — leaving macOS users without a single-click shortcut and inconsistent with VS Code / DataGrip / IntelliJ conventions.
Adds:
Cycle Themeentry under the Help menu in MenuBarcycle-thememenu-actioneventAppLayout.handleActionroutes that id to aDark → Light → Systemcycle via the existinguseThemeStore(mirrorsToolbar.cycleTheme)Files
Test plan
Closes #453